Add example demonstrating ROUNDING_MODE with ROUND_DOWN#5235
Open
devnexen wants to merge 1 commit intophp:masterfrom
Open
Add example demonstrating ROUNDING_MODE with ROUND_DOWN#5235devnexen wants to merge 1 commit intophp:masterfrom
devnexen wants to merge 1 commit intophp:masterfrom
Conversation
Add a code example showing how to use NumberFormatter::ROUNDING_MODE with NumberFormatter::ROUND_DOWN to truncate values to a specified number of fraction digits without rounding. This addresses user confusion about how to truncate rather than round values when using FRACTION_DIGITS. See: php/php-src#21048 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lacatoire
approved these changes
Feb 2, 2026
Contributor
|
LGTM! This addresses the confusion reported in php/php-src#21048, where a user was unaware that |
Member
Author
|
Thanks please do not merge I m waiting gina opinion whether the XML used is appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NumberFormatter::ROUNDING_MODEwithNumberFormatter::ROUND_DOWNto truncate values to a specified number of fraction digits without rounding🤖 Generated with Claude Code